BogaudioModules

commit 9fcee2b3b5e7d6810a159d6755d053cd2423bfb5
parent 7d4661a5562d7133c0f257e04fdd62d78468d1ba
Author: Matt Demanett <matt@demanett.net>
Date:   Wed, 24 Jan 2018 01:02:42 -0500

Detune: remove quantize button; the effect is too small to bother.

Diffstat:
M
res-src/Detune-src.svg
 | 
21
+++------------------
M
res/Detune.svg
 | 
0

M
src/Detune.cpp
 | 
20
++++----------------

3 files changed, 7 insertions(+), 34 deletions(-)
diff --git a/res-src/Detune-src.svg b/res-src/Detune-src.svg
@@ -69,16 +69,6 @@
       </g>
     </symbol>
 
-    <symbol id="button" viewBox="0 0 9px 9px">
-      <g transform="translate(4.5 4.5)">
-        <circle cx="0" cy="0" r="4.1" stroke-width="1" stroke="#00f" fill="#f00" />
-      </g>
-    </symbol>
-
-    <symbol id="light" viewBox="0 0 1.1px 1.1px">
-      <rect width="3.2" height="3.2" fill="#0f0" />
-    </symbol>
-
     <symbol id="input" viewBox="0 0 24px 24px">
       <g transform="translate(12 12)">
         <circle cx="0" cy="0" r="5" stroke-width="1" stroke="#0f0" fill="#0f0" />
@@ -101,7 +91,7 @@
 
   <!-- <polyline points="22.5,0 22.5,380" stroke-width="0.5" stroke="#0f0" /> -->
   <!-- <rect width="45" height="10" fill="#0f0" transform="translate(0 64)" /> -->
-  <!-- <rect width="45" height="10" fill="#0f0" transform="translate(0 125)" /> -->
+  <!-- <rect width="45" height="10" fill="#0f0" transform="translate(0 113)" /> -->
 
   <g transform="rotate(-90) translate(-376 13)">
     <text class="title" font-size="7pt" letter-spacing="2.5px">DETUNE</text>
@@ -118,17 +108,12 @@
   </g>
 
   <g transform="translate(5.5 74)">
-    <rect width="34" height="51" rx="5" fill="#fafafa" />
+    <rect width="34" height="39" rx="5" fill="#fafafa" />
     <use id="CV_INPUT" xlink:href="#input" transform="translate(5 3)" />
     <text font-size="5pt" letter-spacing="2px" transform="translate(11 35)">CV</text>
-    <g transform="translate(3 39)">
-      <text font-size="5pt" letter-spacing="1px" transform="translate(0 7)">QZ</text>
-      <use id="QUANTIZE_LIGHT" xlink:href="#light" transform="translate(12.5 3)" />
-      <use id="QUANTIZE_PARAM" xlink:href="#button" transform="translate(18.5 0)" />
-    </g>
   </g>
 
-  <g transform="translate(0 135)">
+  <g transform="translate(0 123)">
     <g transform="translate(5.5 0)">
       <rect width="34" height="10" fill="#fafafa" transform="translate(0 28)" />
       <rect width="34" height="35" rx="5" fill="#fafafa" />
diff --git a/res/Detune.svg b/res/Detune.svg
Binary files differ.
diff --git a/src/Detune.cpp b/src/Detune.cpp
@@ -7,7 +7,6 @@ using namespace bogaudio::dsp;
 struct Detune : Module {
 	enum ParamsIds {
 		CENTS_PARAM,
-		QUANTIZE_PARAM,
 		NUM_PARAMS
 	};
 
@@ -25,19 +24,16 @@ struct Detune : Module {
 	};
 
 	enum LightsIds {
-		QUANTIZE_LIGHT,
 		NUM_LIGHTS
 	};
 
 	Detune() : Module(NUM_PARAMS, NUM_INPUTS, NUM_OUTPUTS, NUM_LIGHTS) {
-		reset();
 	}
 
 	virtual void step() override;
 };
 
 void Detune::step() {
-	lights[QUANTIZE_LIGHT].value = params[QUANTIZE_PARAM].value > 0.5;
 	if (!(outputs[OUT_PLUS_OUTPUT].active || outputs[OUT_MINUS_OUTPUT].active || outputs[THRU_OUTPUT].active)) {
 		return;
 	}
@@ -45,8 +41,6 @@ void Detune::step() {
 	float cents = params[CENTS_PARAM].value;
 	if (inputs[CV_INPUT].active) {
 		cents *= clampf(inputs[CV_INPUT].value, 0.0, 10.0) / 10.0;
-	}
-	if (params[QUANTIZE_PARAM].value > 0.5) {
 		cents = roundf(cents);
 	}
 	cents /= 100.0;
@@ -95,16 +89,13 @@ DetuneWidget::DetuneWidget() {
 
 	// generated by svg_widgets.rb
 	auto centsParamPosition = Vec(9.5, 32.5);
-	auto quantizeParamPosition = Vec(26.9, 112.9);
 
 	auto cvInputPosition = Vec(10.5, 77.0);
-	auto inInputPosition = Vec(10.5, 138.0);
-
-	auto thruOutputPosition = Vec(10.5, 176.0);
-	auto outPlusOutputPosition = Vec(10.5, 212.0);
-	auto outMinusOutputPosition = Vec(10.5, 248.0);
+	auto inInputPosition = Vec(10.5, 126.0);
 
-	auto quantizeLightPosition = Vec(21.0, 116.0);
+	auto thruOutputPosition = Vec(10.5, 164.0);
+	auto outPlusOutputPosition = Vec(10.5, 200.0);
+	auto outMinusOutputPosition = Vec(10.5, 236.0);
 	// end generated by svg_widgets.rb
 
 	{
@@ -112,7 +103,6 @@ DetuneWidget::DetuneWidget() {
 		dynamic_cast<Knob*>(w)->snap = true;
 		addParam(w);
 	}
-	addParam(createParam<StatefulButton9>(quantizeParamPosition, module, Detune::QUANTIZE_PARAM, 0.0, 1.0, 1.0));
 
 	addInput(createInput<Port24>(cvInputPosition, module, Detune::CV_INPUT));
 	addInput(createInput<Port24>(inInputPosition, module, Detune::IN_INPUT));
@@ -120,6 +110,4 @@ DetuneWidget::DetuneWidget() {
 	addOutput(createOutput<Port24>(thruOutputPosition, module, Detune::THRU_OUTPUT));
 	addOutput(createOutput<Port24>(outPlusOutputPosition, module, Detune::OUT_PLUS_OUTPUT));
 	addOutput(createOutput<Port24>(outMinusOutputPosition, module, Detune::OUT_MINUS_OUTPUT));
-
-	addChild(createLight<TinyLight<GreenLight>>(quantizeLightPosition, module, Detune::QUANTIZE_LIGHT));
 }