DPF

commit 283e9c3dab4c2d85917c388d1edb27a00e86d0d2
parent b2e683e411749bbb4d5da7415262f4c708f743b0
Author: falkTX <falktx@falktx.com>
Date:   Wed,  8 Sep 2021 15:59:55 +0100

Fix some compiler warnings

Diffstat:
M
distrho/src/DistrhoPluginLV2.cpp
 | 
15
++++++++++++---
M
distrho/src/DistrhoUIPrivateData.hpp
 | 
4
++--
M
examples/EmbedExternalUI/EmbedExternalExampleUI.cpp
 | 
4
----

3 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/distrho/src/DistrhoPluginLV2.cpp b/distrho/src/DistrhoPluginLV2.cpp
@@ -84,10 +84,12 @@ public:
           fPortControls(nullptr),
           fLastControlValues(nullptr),
           fSampleRate(sampleRate),
+#if DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
+          fCtrlInPortChangeReq(ctrlInPortChangeReq),
+#endif
           fURIDs(uridMap),
           fUridMap(uridMap),
-          fWorker(worker),
-          fCtrlInPortChangeReq(ctrlInPortChangeReq)
+          fWorker(worker)
     {
 #if DISTRHO_PLUGIN_NUM_INPUTS > 0
         for (uint32_t i=0; i < DISTRHO_PLUGIN_NUM_INPUTS; ++i)
@@ -157,6 +159,11 @@ public:
         // unused
         (void)fWorker;
 #endif
+
+#if ! DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
+        // unused
+        (void)ctrlInPortChangeReq;
+#endif
     }
 
     ~PluginLv2()
@@ -1178,9 +1185,11 @@ private:
     } fURIDs;
 
     // LV2 features
+#if DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
+    const LV2_ControlInputPort_Change_Request* const fCtrlInPortChangeReq;
+#endif
     const LV2_URID_Map* const fUridMap;
     const LV2_Worker_Schedule* const fWorker;
-    const LV2_ControlInputPort_Change_Request* const fCtrlInPortChangeReq;
 
 #if DISTRHO_PLUGIN_WANT_STATE
     StringToStringMap fStateMap;
diff --git a/distrho/src/DistrhoUIPrivateData.hpp b/distrho/src/DistrhoUIPrivateData.hpp
@@ -52,14 +52,14 @@ START_NAMESPACE_DGL
 #if DISTRHO_PLUGIN_HAS_EXTERNAL_UI
 struct PluginApplication
 {
-    IdleCallback* idleCallback;
+    DGL_NAMESPACE::IdleCallback* idleCallback;
     UI* ui;
 
     explicit PluginApplication()
         : idleCallback(nullptr),
           ui(nullptr) {}
 
-    void addIdleCallback(IdleCallback* const cb)
+    void addIdleCallback(DGL_NAMESPACE::IdleCallback* const cb)
     {
         DISTRHO_SAFE_ASSERT_RETURN(cb != nullptr,);
         DISTRHO_SAFE_ASSERT_RETURN(idleCallback == nullptr,);
diff --git a/examples/EmbedExternalUI/EmbedExternalExampleUI.cpp b/examples/EmbedExternalUI/EmbedExternalExampleUI.cpp
@@ -473,10 +473,6 @@ protected:
 
     // -------------------------------------------------------------------------------------------------------
 
-private:
-    // Current value, cached for when UI becomes visible
-    float fValue;
-
    /**
       Set our UI class as non-copyable and add a leak detector just in case.
     */