NeuralPi

commit 11ac4b4dfb5e9304b5e3b9282033632732ef9371
parent 60020375d7a5994d6919a29aea4bcb52c2084765
Author: Keith Bloemer <32459398+GuitarML@users.noreply.github.com>
Date:   Wed, 10 Nov 2021 17:32:25 -0600

Merge pull request #16 from GermanAizek/main

Minor fixes: use std::move and lower scope
Diffstat:
M
Source/AmpOSCReceiver.h
 | 
2
+-
M
Source/CabSim.h
 | 
5
+----
M
Source/PluginEditor.cpp
 | 
6
+++---

3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/Source/AmpOSCReceiver.h b/Source/AmpOSCReceiver.h
@@ -80,7 +80,7 @@ public:
 
     void updateAmpName (String name)
     {
-        ampName = name;
+        ampName = std::move(name);
         buildAddressPatterns();
     }
 
diff --git a/Source/CabSim.h b/Source/CabSim.h
@@ -14,10 +14,7 @@ class CabSim
 {
 public:
     //==============================================================================
-    CabSim()
-    {
-
-    }
+    CabSim() = default;
 
     //==============================================================================
     void prepare (const juce::dsp::ProcessSpec& spec)
diff --git a/Source/PluginEditor.cpp b/Source/PluginEditor.cpp
@@ -649,8 +649,8 @@ void NeuralPiAudioProcessorEditor::resized()
 void NeuralPiAudioProcessorEditor::modelSelectChanged()
 {
     const int selectedFileIndex = modelSelect.getSelectedItemIndex();
-    File selectedFile = processor.userAppDataDirectory_tones.getFullPathName() + "/" + modelSelect.getText() + ".json";
     if (selectedFileIndex >= 0 && selectedFileIndex < processor.jsonFiles.size()) {
+        File selectedFile = processor.userAppDataDirectory_tones.getFullPathName() + "/" + modelSelect.getText() + ".json";
         //processor.loadConfig(processor.jsonFiles[selectedFileIndex]);
         processor.loadConfig(selectedFile);
         processor.current_model_index = selectedFileIndex;
@@ -663,8 +663,8 @@ void NeuralPiAudioProcessorEditor::modelSelectChanged()
 void NeuralPiAudioProcessorEditor::irSelectChanged()
 {
     const int selectedFileIndex = irSelect.getSelectedItemIndex();
-    File selectedFile = processor.userAppDataDirectory_irs.getFullPathName() + "/" + irSelect.getText() + ".wav";
     if (selectedFileIndex >= 0 && selectedFileIndex < processor.irFiles.size()) {
+        File selectedFile = processor.userAppDataDirectory_irs.getFullPathName() + "/" + irSelect.getText() + ".wav";
         //processor.loadIR(processor.irFiles[selectedFileIndex]);
         processor.loadIR(selectedFile);
         processor.current_ir_index = selectedFileIndex;
@@ -889,7 +889,7 @@ void NeuralPiAudioProcessorEditor::connectSender()
 
 void NeuralPiAudioProcessorEditor::updateOutgoingIP(String ip)
 {
-    outgoingIP = ip;
+    outgoingIP = std::move(ip);
     connectSender();
 }