clap

commit ed3d5de91ed9883acbf810c2af8a4bc89d3f6011
parent 6063d4d4d30f9041407a1274f62704241323824e
Author: Alexandre BIQUE <bique.alexandre@gmail.com>
Date:   Sat,  1 May 2021 02:08:47 +0200

Post review with wrl and x42

Diffstat:
M
include/clap/ext/audio-ports.h
 | 
2
+-
M
include/clap/ext/gui-cocoa.h
 | 
3
---
M
include/clap/ext/gui-win32.h
 | 
3
---
M
include/clap/ext/gui-x11.h
 | 
3
---

4 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/include/clap/ext/audio-ports.h b/include/clap/ext/audio-ports.h
@@ -22,7 +22,7 @@ typedef enum clap_audio_port_channel_mapping {
 
 typedef struct clap_audio_port_info {
    uint32_t id;                   // stable identifier
-   char     name[CLAP_NAME_SIZE]; // displayable name
+   char     name[CLAP_NAME_SIZE]; // displayable name, i18n?
    bool     is_main;              // there can only be 1 main input and output
    bool     is_cv;                // control voltage
    bool     supports_64_bits;     // 32 bit support is mandatory, the host chooses
diff --git a/include/clap/ext/gui-cocoa.h b/include/clap/ext/gui-cocoa.h
@@ -11,9 +11,6 @@ extern "C" {
 typedef struct clap_plugin_embed_cocoa {
    // [main-thread]
    bool (*attach)(clap_plugin *plugin, void *nsView);
-
-   // [main-thread]
-   bool (*detach)(clap_plugin *plugin);
 } clap_plugin_embed_cocoa;
 
 #ifdef __cplusplus
diff --git a/include/clap/ext/gui-win32.h b/include/clap/ext/gui-win32.h
@@ -14,9 +14,6 @@ typedef void *clap_hwnd;
 typedef struct clap_plugin_gui_win32 {
    // [main-thread]
    bool (*attach)(clap_plugin *plugin, clap_hwnd window);
-
-   // [main-thread]
-   bool (*detach)(clap_plugin *plugin);
 } clap_plugin_gui_win32;
 
 #ifdef __cplusplus
diff --git a/include/clap/ext/gui-x11.h b/include/clap/ext/gui-x11.h
@@ -14,9 +14,6 @@ typedef struct clap_plugin_gui_x11 {
    bool (*attach)(clap_plugin * plugin,
                   const char *  display_name,
                   unsigned long window);
-
-   // [main-thread]
-   bool (*detach)(clap_plugin *plugin);
 } clap_plugin_gui_x11;
 
 #ifdef __cplusplus