gearmulator

Emulation of classic VA synths of the late 90s/2000s that are based on Motorola 56300 family DSPs
Log | Files | Refs | Submodules | README | LICENSE

commit 3eb8f412b5be6e466333c0f1c80de5fc89e6e475
parent 29d4e30cbf58b6ef2fb23a01dce54f19bde4a14d
Author: dsp56300 <dsp56300@users.noreply.github.com>
Date:   Tue, 13 Aug 2024 19:37:52 +0200

fix too many waveforms displayed for Oscillator 1/2

Diffstat:
Mdoc/changelog.txt | 6++++--
Msource/jucePluginLib/parameterbinding.cpp | 5++++-
2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/doc/changelog.txt b/doc/changelog.txt @@ -4,11 +4,13 @@ Release Notes Framework: -- [Fix] CLAP: Ranges of discrete parameters were not reported properly +- [Fix] CLAP: Ranges of discrete parameters were not reported properly, + causing automation issues Osirus: -- [FIX] FX settings were not restored in Multi Mode +- [Fix] FX settings were not restored in Multi Mode +- [Fix] Too many waveforms displayed for Oscillator 1/2 1.3.18 diff --git a/source/jucePluginLib/parameterbinding.cpp b/source/jucePluginLib/parameterbinding.cpp @@ -108,6 +108,7 @@ namespace pluginLib const auto& desc = v->getDescription(); const auto& valueList = desc.valueList; + const auto& range = desc.range; if(valueList.order.empty()) { @@ -115,7 +116,7 @@ namespace pluginLib const auto& allValues = v->getAllValueStrings(); for (const auto& vs : allValues) { - if(vs.isNotEmpty()) + if(vs.isNotEmpty() && i >= range.getStart() && i <= range.getEnd()) sortedValues.emplace_back(i, vs.toStdString()); ++i; } @@ -127,6 +128,8 @@ namespace pluginLib const auto value = valueList.orderToValue(i); if(value == ValueList::InvalidIndex) continue; + if(i < range.getStart() || i > range.getEnd()) + continue; const auto text = valueList.valueToText(value); if(text.empty()) continue;