gearmulator

commit 40c88bdf53e4e5661ee3adfce8307c10ac167c17
parent 856eb4283002022c20017770137f6762c4bb62b7
Author: dsp56300 <dsp56300@users.noreply.github.com>
Date:   Wed,  4 Dec 2024 20:28:37 +0100

add default parameter to checksum calculation

Diffstat:
M
source/virusJucePlugin/PatchManager.cpp
 | 
2
+-
M
source/virusJucePlugin/VirusProcessor.cpp
 | 
2
+-
M
source/virusLib/demoplayback.cpp
 | 
2
+-
M
source/virusLib/device.cpp
 | 
6
+++---
M
source/virusLib/microcontroller.cpp
 | 
4
++--
M
source/virusLib/microcontroller.h
 | 
2
+-

6 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/source/virusJucePlugin/PatchManager.cpp b/source/virusJucePlugin/PatchManager.cpp
@@ -337,7 +337,7 @@ namespace genericVirusUI
 									{0xf0, 0x00, 0x20, 0x33, 0x01, virusLib::OMNI_DEVICE_ID, 0x10, static_cast<uint8_t>(0x01 + (i >> 7)), static_cast<uint8_t>(i & 0x7f)}
 								);
 								sysex.insert(sysex.end(), data.begin() + i * 0x100 + startAddr, data.begin() + i * 0x100 + 0x100 + startAddr);
-								sysex.push_back(virusLib::Microcontroller::calcChecksum(sysex, 5));
+								sysex.push_back(virusLib::Microcontroller::calcChecksum(sysex));
 								sysex.push_back(0xf7);
 							}
 						}
diff --git a/source/virusJucePlugin/VirusProcessor.cpp b/source/virusJucePlugin/VirusProcessor.cpp
@@ -191,7 +191,7 @@ namespace virus
 
 				lv2Preset.data = {0xf0, 0x00, 0x20, 0x33, 01, virusLib::OMNI_DEVICE_ID, virusLib::DUMP_SINGLE, virusLib::toMidiByte(virusLib::BankNumber::EditBuffer), virusLib::SINGLE};
 				lv2Preset.data.insert(lv2Preset.data.end(), preset.begin(), preset.begin() + virusLib::ROMFile::getSinglePresetSize(_rom.getModel()));
-				lv2Preset.data.push_back(virusLib::Microcontroller::calcChecksum(lv2Preset.data, 5));
+				lv2Preset.data.push_back(virusLib::Microcontroller::calcChecksum(lv2Preset.data));
 				lv2Preset.data.push_back(0xf7);
 
 				lv2Preset.name = virusLib::ROMFile::getSingleName(preset);
diff --git a/source/virusLib/demoplayback.cpp b/source/virusLib/demoplayback.cpp
@@ -197,7 +197,7 @@ namespace virusLib
 
 				// checksum needs to be updated
 				s.pop_back();
-				Microcontroller::calcChecksum(s, 5);
+				Microcontroller::calcChecksum(s);
 				s.push_back(0xf7);
 
 				std::stringstream ss;
diff --git a/source/virusLib/device.cpp b/source/virusLib/device.cpp
@@ -355,7 +355,7 @@ namespace virusLib
 				// pack into sysex
 				std::vector<uint8_t>& sysex = _sysexPresets.emplace_back(std::vector<uint8_t>{0xf0, 0x00, 0x20, 0x33, 0x01, OMNI_DEVICE_ID, 0x10, 0x01, programIndex});
 				sysex.insert(sysex.end(), _data.begin() + pos, _data.begin() + pos + presetSize);
-				sysex.push_back(Microcontroller::calcChecksum(sysex, 5));
+				sysex.push_back(Microcontroller::calcChecksum(sysex));
 				sysex.push_back(0xf7);
 
 				++numFound;
@@ -410,10 +410,10 @@ namespace virusLib
 
 			for(size_t j=0; j<256; ++j)
 				sysex.push_back(preset[j]);
-			sysex.push_back(Microcontroller::calcChecksum(sysex, 5));
+			sysex.push_back(Microcontroller::calcChecksum(sysex));
 			for(size_t j=256; j<512; ++j)
 				sysex.push_back(preset[j]);
-			sysex.push_back(Microcontroller::calcChecksum(sysex, 5));
+			sysex.push_back(Microcontroller::calcChecksum(sysex));
 			sysex.push_back(0xf7);
 
 			++presetIdx;
diff --git a/source/virusLib/microcontroller.cpp b/source/virusLib/microcontroller.cpp
@@ -542,7 +542,7 @@ bool Microcontroller::sendSysex(const std::vector<uint8_t>& _data, std::vector<S
 			response.push_back(_dump[i]);
 
 		// checksum for ABC models comes after 256 bytes of preset data
-		response.push_back(calcChecksum(response, 5));
+		response.push_back(calcChecksum(response));
 
 		if (size > modelABCsize)
 		{
@@ -550,7 +550,7 @@ bool Microcontroller::sendSysex(const std::vector<uint8_t>& _data, std::vector<S
 				response.push_back(_dump[i]);
 
 			// Second checksum for D model: That checksum is to be calculated over the whole preset data, including the ABC checksum
-			response.push_back(calcChecksum(response, 5));
+			response.push_back(calcChecksum(response));
 		}
 
 		response.push_back(M_ENDOFSYSEX);
diff --git a/source/virusLib/microcontroller.h b/source/virusLib/microcontroller.h
@@ -56,7 +56,7 @@ public:
 	static PresetVersion getPresetVersion(const TPreset& _preset);
 	static PresetVersion getPresetVersion(uint8_t _versionCode);
 
-	static uint8_t calcChecksum(const std::vector<uint8_t>& _data, const size_t _offset);
+	static uint8_t calcChecksum(const std::vector<uint8_t>& _data, size_t _offset = 5);
 
 	bool dspHasBooted() const;