gearmulator

commit 673387a28fbd13c3cf69f34a3b1acf4c7a8a1777
parent ab79788e7b966982555578ff80e9d4b8a20f4909
Author: dsp56300 <dsp56300@users.noreply.github.com>
Date:   Fri, 19 Apr 2024 19:17:56 +0200

Merge branch 'oss/osirus' into oss/osTIrus

# Conflicts:
#	doc/changelog.txt

Diffstat:
M
doc/changelog.txt
 | 
4
++++
M
source/jucePluginEditorLib/focusedParameter.cpp
 | 
52
++++++++++++++++++++++++++++++++--------------------
M
source/jucePluginEditorLib/focusedParameter.h
 | 
2
++

3 files changed, 38 insertions(+), 20 deletions(-)
diff --git a/doc/changelog.txt b/doc/changelog.txt
@@ -2,6 +2,10 @@ Release Notes
 
 1.3.12
 
+Framework:
+
+- [Fix] VST3 plugins were rejected by some hosts on macOS
+
 OsTIrus:
 
 - [Fix] Delay Time knob is now disabled if not applicable
diff --git a/source/jucePluginEditorLib/focusedParameter.cpp b/source/jucePluginEditorLib/focusedParameter.cpp
@@ -60,6 +60,34 @@ namespace jucePluginEditorLib
 			updateControlLabel(component);
 	}
 
+	void FocusedParameter::updateParameter(const std::string& _name, const std::string& _value)
+	{
+		if (m_focusedParameterName)
+		{
+			if(_name.empty())
+			{
+				m_focusedParameterName->setVisible(false);
+			}
+			else
+			{
+				m_focusedParameterName->setText(_name, juce::dontSendNotification);
+				m_focusedParameterName->setVisible(true);
+			}
+		}
+		if(m_focusedParameterValue)
+		{
+			if(_value.empty())
+			{
+				m_focusedParameterValue->setVisible(false);
+			}
+			else
+			{
+				m_focusedParameterValue->setText(_value, juce::dontSendNotification);
+				m_focusedParameterValue->setVisible(true);
+			}
+		}
+	}
+
 	void FocusedParameter::timerCallback()
 	{
 		updateControlLabel(nullptr);
@@ -78,10 +106,7 @@ namespace jucePluginEditorLib
 
 		if(!_component || !_component->getProperties().contains("parameter"))
 		{
-			if (m_focusedParameterName)
-				m_focusedParameterName->setVisible(false);
-			if (m_focusedParameterValue)
-				m_focusedParameterValue->setVisible(false);
+			updateParameter({}, {});
 			m_tooltip->setVisible(false);
 			return;
 		}
@@ -102,29 +127,16 @@ namespace jucePluginEditorLib
 		}
 		if(!p)
 		{
-			if (m_focusedParameterName)
-				m_focusedParameterName->setVisible(false);
-			if (m_focusedParameterValue)
-				m_focusedParameterValue->setVisible(false);
+			updateParameter({}, {});
 			m_tooltip->setVisible(false);
 			return;
 		}
 
-		const auto value = p->getText(p->getValue(), 0);
+		const auto value = p->getText(p->getValue(), 0).toStdString();
 
 		const auto& desc = p->getDescription();
 
-		if (m_focusedParameterName)
-		{
-			m_focusedParameterName->setText(desc.displayName, juce::dontSendNotification);
-			m_focusedParameterName->setVisible(true);
-		}
-
-		if (m_focusedParameterValue)
-		{
-			m_focusedParameterValue->setText(value, juce::dontSendNotification);
-			m_focusedParameterValue->setVisible(true);
-		}
+		updateParameter(desc.displayName, value);
 
 		m_tooltip->initialize(_component, value);
 
diff --git a/source/jucePluginEditorLib/focusedParameter.h b/source/jucePluginEditorLib/focusedParameter.h
@@ -31,6 +31,8 @@ namespace jucePluginEditorLib
 
 		void onMouseEnter(const juce::MouseEvent& _event);
 
+		virtual void updateParameter(const std::string& _name, const std::string& _value);
+
 	private:
 		void timerCallback() override;
 		void updateControlLabel(juce::Component* _component);