gearmulator

Emulation of classic VA synths of the late 90s/2000s that are based on Motorola 56300 family DSPs
Log | Files | Refs | Submodules | README | LICENSE

commit c0a21cb853a2d3e6b81c69aaff6fb8e32a46c38f
parent f8e95743908c39f69066da1a6aef44f05c2722bf
Author: dsp56300 <dsp56300@users.noreply.github.com>
Date:   Sun, 13 Mar 2022 01:42:53 +0100

fix various warnings

Diffstat:
Msource/jucePlugin/VirusController.h | 3++-
Msource/jucePlugin/VirusParameterBinding.cpp | 1+
Msource/jucePlugin/VirusParameterBinding.h | 10+++++-----
Msource/jucePlugin/ui2/Ui_Utils.h | 6++++--
4 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/source/jucePlugin/VirusController.h b/source/jucePlugin/VirusController.h @@ -27,7 +27,8 @@ namespace Virus static constexpr auto kNameLength = 10; Controller(AudioPluginAudioProcessor &, unsigned char deviceId = 0x00); - ~Controller(); + ~Controller() override; + // this is called by the plug-in on audio thread! void dispatchVirusOut(const std::vector<synthLib::SMidiEvent> &); diff --git a/source/jucePlugin/VirusParameterBinding.cpp b/source/jucePlugin/VirusParameterBinding.cpp @@ -1,6 +1,7 @@ #include "VirusParameterBinding.h" #include "VirusParameter.h" #include "PluginProcessor.h" + class Parameter; VirusParameterBinding::~VirusParameterBinding() diff --git a/source/jucePlugin/VirusParameterBinding.h b/source/jucePlugin/VirusParameterBinding.h @@ -15,19 +15,19 @@ public: } Virus::Parameter *m_param; juce::Slider* m_slider; - void mouseDown(const juce::MouseEvent &event) { m_param->beginChangeGesture(); }; - void mouseUp(const juce::MouseEvent &event) { m_param->endChangeGesture(); }; - void mouseDrag(const juce::MouseEvent &event) { m_param->setValueNotifyingHost(m_param->convertTo0to1((float)m_slider->getValue())); }; + void mouseDown(const juce::MouseEvent &event) override { m_param->beginChangeGesture(); } + void mouseUp(const juce::MouseEvent &event) override { m_param->endChangeGesture(); } + void mouseDrag(const juce::MouseEvent &event) override { m_param->setValueNotifyingHost(m_param->convertTo0to1(static_cast<float>(m_slider->getValue()))); } }; -class VirusParameterBinding : juce::MouseListener +class VirusParameterBinding final : juce::MouseListener { public: VirusParameterBinding(AudioPluginAudioProcessor &_processor) : m_processor(_processor) { } - ~VirusParameterBinding(); + ~VirusParameterBinding() override; void clearBindings(); void setPart(uint8_t _part); void bind(juce::Slider& _control, Virus::ParameterType _param); diff --git a/source/jucePlugin/ui2/Ui_Utils.h b/source/jucePlugin/ui2/Ui_Utils.h @@ -1,13 +1,15 @@ +#pragma once + #include "Virus_LookAndFeel.h" -#include "../VirusController.h" + #include "../../virusLib/microcontrollerTypes.h" + namespace Trancy { using namespace VirusUI; constexpr auto knobSize = LookAndFeel::kKnobSize; constexpr auto knobSizeSmall = LookAndFeelSmallButton::kKnobSize; - class Controller; using namespace virusLib; static void setupBackground(juce::Component &parent, std::unique_ptr<juce::Drawable> &bg, const void *data,