gearmulator

Emulation of classic VA synths of the late 90s/2000s that are based on Motorola 56300 family DSPs
Log | Files | Refs | Submodules | README | LICENSE

commit f14806fed5ef1c96ac6b20a1c2b67bf191e284ce
parent 87dd001f5e2660902404125cd00fba0617a7e46a
Author: dsp56300 <dsp56300@users.noreply.github.com>
Date:   Sat, 18 May 2024 16:38:19 +0200

[Osirus][OsTIrus][Fix] MIDI Control Change "Bank Select MSB" destroyed the active preset, causing it to sound different when reloaded

Diffstat:
Msource/virusLib/microcontroller.cpp | 6+++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/source/virusLib/microcontroller.cpp b/source/virusLib/microcontroller.cpp @@ -1250,7 +1250,11 @@ void Microcontroller::applyToSingleEditBuffer(TPreset& _single, const Page _page uint32_t offset; switch(_page) { - case PAGE_A: offset = 0; break; + case PAGE_A: + if(_param < g_pageA[0]) // _param 0 (= bank select MSB) destroys the preset version. Skip anything below first valid parameter + return; + offset = 0; + break; case PAGE_B: offset = 1; break; case PAGE_6E: offset = 2; break; case PAGE_6F: offset = 3; break;