reapack

commit 031c627cf21bca2a1c3758c07ccb18427e34c6a4
parent 6ed0b7b888f372d5b243762bbf785eb48f0d6218
Author: cfillion <cfillion@users.noreply.github.com>
Date:   Mon, 23 May 2016 01:48:58 -0400

revert "avoid reloading indexes unless they were updated by the transaction"

This reverts commit 24b775fd2fbb2cbbd21a1d1e1b960bb813be31f9.
It prevented the browser to be reloaded when editing repositories from
the repo manager dialog.

Diffstat:
M
src/browser.hpp
 | 
2
+-
M
src/reapack.cpp
 | 
12
+++---------
M
src/transaction.hpp
 | 
1
-

3 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/browser.hpp b/src/browser.hpp
@@ -44,7 +44,6 @@ class Browser : public Dialog {
 public:
   Browser(ReaPack *);
   void refresh(bool stale = false);
-  void populate();
 
 protected:
   void onInit() override;
@@ -99,6 +98,7 @@ private:
 
   Entry makeEntry(const Package *, const Registry::Entry &) const;
 
+  void populate();
   void transferActions();
   bool match(const Entry &) const;
   void checkFilter();
diff --git a/src/reapack.cpp b/src/reapack.cpp
@@ -506,17 +506,11 @@ Transaction *ReaPack::setupTransaction()
   });
 
   m_tx->setCleanupHandler([=] {
-    // refresh only once all onFinish slots were ran
-    if(m_browser) {
-      // don't reload indexes unless they were modified
-      if(m_tx->updatedIndexes())
-        m_browser->refresh();
-      else
-        m_browser->populate();
-    }
-
     delete m_tx;
     m_tx = nullptr;
+
+    // refresh only once all onFinish slots were ran
+    refreshBrowser();
   });
 
   return m_tx;
diff --git a/src/transaction.hpp b/src/transaction.hpp
@@ -61,7 +61,6 @@ public:
   bool isCancelled() const { return m_isCancelled; }
   const Receipt &receipt() const { return m_receipt; }
   size_t taskCount() const { return m_tasks.size(); }
-  bool updatedIndexes() const { return !m_remotes.empty(); }
 
   DownloadQueue *downloadQueue() { return &m_downloadQueue; }