commit 2e2c4d5973085d9ddfea8c9b6a05a326bafcec21
parent 6281e859198c308732d3efcc721d02a7919f4fec
Author: cfillion <cfillion@users.noreply.github.com>
Date: Wed, 20 Jun 2018 01:16:16 -0400
add forgotten virtual destructors
thanks clang 6!
Diffstat:
4 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/about.hpp b/src/about.hpp
@@ -82,6 +82,8 @@ class AboutDelegate {
protected:
friend About;
+ virtual ~AboutDelegate() = default;
+
virtual void init(About *) = 0;
virtual void updateList(int) = 0;
virtual bool fillContextMenu(Menu &, int) const = 0;
diff --git a/src/control.hpp b/src/control.hpp
@@ -31,7 +31,7 @@ class Dialog;
class Control {
public:
Control(HWND handle) : m_handle(handle) {}
- virtual ~Control() {}
+ virtual ~Control() = default;
HWND handle() const { return m_handle; }
diff --git a/src/filter.hpp b/src/filter.hpp
@@ -47,6 +47,7 @@ private:
};
Node(int flags) : m_flags(flags) {}
+ virtual ~Node() = default;
virtual bool match(const std::vector<std::string> &) const = 0;
bool test(Flag f) const { return (m_flags & f) != 0; }
@@ -67,6 +68,7 @@ private:
Group(Type type, int flags = 0, Group *parent = nullptr);
void clear() { m_nodes.clear(); }
Group *push(std::string, int *flags);
+
bool match(const std::vector<std::string> &) const override;
private:
diff --git a/src/task.hpp b/src/task.hpp
@@ -42,7 +42,7 @@ typedef std::shared_ptr<const Index> IndexPtr;
class Task {
public:
Task(Transaction *parent) : m_tx(parent) {}
- virtual ~Task() {}
+ virtual ~Task() = default;
virtual bool start() { return true; }
virtual void commit() = 0;