commit 4b15951a7631c2bdbe1b078ab84e22c7c3dc1101
parent dccaed3aab9fb8823523a2d04827162a86dc6719
Author: cfillion <cfillion@users.noreply.github.com>
Date: Sun, 26 Aug 2018 00:13:54 -0400
use fallthrough attribute instead of comment
Diffstat:
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/browser.cpp b/src/browser.cpp
@@ -184,6 +184,7 @@ void Browser::onCommand(const int id, const int event)
}
else
break;
+ [[fallthrough]];
case IDCANCEL:
if(m_loadState == Loading)
hide(); // keep ourselves alive
diff --git a/src/database.cpp b/src/database.cpp
@@ -169,7 +169,7 @@ void Statement::exec(const ExecCallback &callback)
case SQLITE_ROW:
if(callback())
break;
- // FALLTHROUGH
+ [[fallthrough]];
case SQLITE_DONE:
sqlite3_clear_bindings(m_stmt);
sqlite3_reset(m_stmt);
diff --git a/src/manager.cpp b/src/manager.cpp
@@ -190,7 +190,7 @@ void Manager::onCommand(const int id, int)
refresh();
break;
}
- // FALLTHRU
+ [[fallthrough]];
case IDCANCEL:
close();
break;
@@ -696,7 +696,7 @@ void NetworkConfig::onCommand(const int id, int)
switch(id) {
case IDOK:
apply();
- // FALLTHROUGH
+ [[fallthrough]];
case IDCANCEL:
close(id);
break;
diff --git a/src/registry.cpp b/src/registry.cpp
@@ -128,15 +128,16 @@ void Registry::migrate()
switch(current.minor) {
case 1:
m_db.exec("ALTER TABLE entries ADD COLUMN pinned INTEGER NOT NULL DEFAULT 0;");
- // FALLTHROUGH
+ [[fallthrough]];
case 2:
m_db.exec("ALTER TABLE files ADD COLUMN type INTEGER NOT NULL DEFAULT 0;");
- // FALLTHROUGH
+ [[fallthrough]];
case 3:
m_db.exec("ALTER TABLE entries ADD COLUMN desc TEXT NOT NULL DEFAULT '';");
- // FALLTHROUGH
+ [[fallthrough]];
case 4:
convertImplicitSections();
+ break;
}
m_db.setVersion(version);