reapack

Package manager for REAPER
Log | Files | Refs | Submodules | README | LICENSE

commit 566c60d98c6df5302afc6c4ce74e88c3a2ed267e
parent d0338ba7fe3b6377b3fe50c906fb8bcac2fa9960
Author: cfillion <cfillion@users.noreply.github.com>
Date:   Wed,  5 Jan 2022 22:41:35 -0500

dialog: use explicit per-message return values from the dialog procedure

Diffstat:
Msrc/dialog.cpp | 20++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/dialog.cpp b/src/dialog.cpp @@ -48,30 +48,30 @@ WDL_DLGRET Dialog::Proc(HWND handle, UINT msg, WPARAM wParam, LPARAM lParam) SetWindowLongPtr(handle, GWLP_USERDATA, lParam); dlg->m_handle = handle; dlg->onInit(); - break; + return 1; case WM_TIMER: dlg->onTimer(static_cast<int>(wParam)); - break; + return 0; case WM_COMMAND: dlg->onCommand(LOWORD(wParam), HIWORD(wParam)); - break; + return 0; case WM_NOTIFY: dlg->onNotify(reinterpret_cast<LPNMHDR>(lParam), lParam); - break; + return 0; case WM_CONTEXTMENU: dlg->onContextMenu(reinterpret_cast<HWND>(wParam), GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)); - break; + return 0; case WM_GETMINMAXINFO: { MINMAXINFO *mmi = reinterpret_cast<MINMAXINFO *>(lParam); mmi->ptMinTrackSize.x = dlg->m_minimumSize.x; mmi->ptMinTrackSize.y = dlg->m_minimumSize.y; - break; + return 0; } case WM_SIZE: if(wParam != SIZE_MINIMIZED) dlg->onResize(); - break; + return 0; #ifdef __APPLE__ // This stops SWELL_SendMouseMessageImpl from continuously resetting the // mouse cursor allowing NSTextViews to change it on mouse hover. @@ -80,10 +80,10 @@ WDL_DLGRET Dialog::Proc(HWND handle, UINT msg, WPARAM wParam, LPARAM lParam) #endif case WM_DESTROY: dlg->onClose(); - break; + return 0; + default: + return 0; }; - - return false; } int Dialog::HandleKey(MSG *msg, accelerator_register_t *accel)