reapack

commit a57bcb75f6192b377df599013e8380f91d5e1025
parent 42d3acf09a173889eb59d8261468eb1a5ad845e0
Author: cfillion <cfillion@users.noreply.github.com>
Date:   Mon,  1 Aug 2016 15:18:12 -0400

browser: slight refactoring of obsolete package detection

Diffstat:
M
src/browser.cpp
 | 
12
+++++-------

1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/browser.cpp b/src/browser.cpp
@@ -537,9 +537,9 @@ void Browser::populate()
 
     m_currentIndex = -1;
 
-    // prevent #fillList from trying to restore the selection
-    // (entry indexes may mismatch depending on the new repository contents,
-    // thus causing the wrong package to be selected)
+    // Prevent #fillList from trying to restore the selection as
+    // entry indexes may mismatch depending on the new repository contents
+    // thus causing the wrong package to be selected!
     m_visibleEntries.clear();
 
     for(IndexPtr index : m_indexes) {
@@ -550,10 +550,8 @@ void Browser::populate()
       for(const Registry::Entry &regEntry : reg.getEntries(index->name())) {
         const Category *cat = index->category(regEntry.category);
 
-        if(cat && cat->package(regEntry.package))
-          continue;
-
-        m_entries.push_back({InstalledFlag | ObsoleteFlag, regEntry});
+        if(!cat || !cat->package(regEntry.package))
+          m_entries.push_back({InstalledFlag | ObsoleteFlag, regEntry});
       }
     }