commit fd6a3b5b9f49dfae00e304317b1c83ef34f9a4e1
parent 2188cc6523d0cbef4e69a62d427ff466a8db2302
Author: cfillion <cfillion@users.noreply.github.com>
Date: Tue, 29 Aug 2017 02:33:10 -0400
receive more stuff as const reference, especially boost::format::operator%
Diffstat:
10 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/archive.cpp b/src/archive.cpp
@@ -256,7 +256,7 @@ size_t Archive::create(const auto_string &path, vector<string> *errors,
if(FS::exists(path))
jobs.push_back(new FileCompressor(path, writer));
else {
- const auto fmt = format("%s (%s)") % path.join() % FS::lastError();
+ const auto &fmt = format("%s (%s)") % path.join() % FS::lastError();
errors->push_back(fmt.str());
}
};
diff --git a/src/browser.cpp b/src/browser.cpp
@@ -658,7 +658,7 @@ void Browser::installVersion(const int index, const size_t verIndex)
if(!entry)
return;
- const auto versions = entry->package->versions();
+ const auto &versions = entry->package->versions();
if(verIndex >= versions.size())
return;
@@ -740,7 +740,7 @@ void Browser::updateAction(const int index)
if(!entry)
return;
- const auto it = find(m_actions.begin(), m_actions.end(), entry);
+ const auto &it = find(m_actions.begin(), m_actions.end(), entry);
if(!entry->target && (!entry->pin || !entry->canPin())) {
if(it != m_actions.end())
m_actions.erase(it);
diff --git a/src/dialog.cpp b/src/dialog.cpp
@@ -40,7 +40,7 @@ WDL_DLGRET Dialog::Proc(HWND handle, UINT msg, WPARAM wParam, LPARAM lParam)
if(msg == WM_INITDIALOG)
dlg = reinterpret_cast<Dialog *>(lParam);
else {
- const auto it = Dialog::s_instances.find(handle);
+ const auto &it = Dialog::s_instances.find(handle);
if(it == Dialog::s_instances.end())
return false;
else
@@ -463,7 +463,7 @@ void Dialog::onCommand(const int id, int)
void Dialog::onNotify(LPNMHDR info, LPARAM lParam)
{
- const auto it = m_controls.find((int)info->idFrom);
+ const auto &it = m_controls.find((int)info->idFrom);
if(it != m_controls.end())
it->second->onNotify(info, lParam);
diff --git a/src/download.cpp b/src/download.cpp
@@ -68,7 +68,7 @@ DownloadContext::DownloadContext()
{
m_curl = curl_easy_init();
- const auto userAgent = format("ReaPack/%s REAPER/%s")
+ const auto &userAgent = format("ReaPack/%s REAPER/%s")
% ReaPack::VERSION % GetAppVersion();
curl_easy_setopt(m_curl, CURLOPT_USERAGENT, userAgent.str().c_str());
@@ -142,7 +142,7 @@ bool Download::run()
closeStream();
if(res != CURLE_OK) {
- const auto err = format("%s (%d): %s") % curl_easy_strerror(res) % res % errbuf;
+ const auto &err = format("%s (%d): %s") % curl_easy_strerror(res) % res % errbuf;
setError({err.str(), m_url});
return false;
}
diff --git a/src/index.cpp b/src/index.cpp
@@ -120,7 +120,7 @@ bool Index::addCategory(const Category *cat)
const Category *Index::category(const string &name) const
{
- const auto it = m_catMap.find(name);
+ const auto &it = m_catMap.find(name);
if(it == m_catMap.end())
return nullptr;
@@ -169,7 +169,7 @@ bool Category::addPackage(const Package *pkg)
const Package *Category::package(const string &name) const
{
- const auto it = m_pkgMap.find(name);
+ const auto &it = m_pkgMap.find(name);
if(it == m_pkgMap.end())
return nullptr;
diff --git a/src/listview.cpp b/src/listview.cpp
@@ -168,7 +168,7 @@ void ListView::sortByColumn(const int index, const SortOrder order, const bool u
if(m_sort)
setSortArrow(false);
- const auto settings = Sort(index, order);
+ const Sort settings(index, order);
if(!user)
m_defaultSort = settings;
diff --git a/src/manager.cpp b/src/manager.cpp
@@ -395,7 +395,7 @@ void Manager::setRemoteEnabled(const bool enabled)
bool Manager::isRemoteEnabled(const Remote &remote) const
{
- const auto it = m_mods.find(remote);
+ const auto &it = m_mods.find(remote);
if(it == m_mods.end())
return remote.isEnabled();
@@ -418,7 +418,7 @@ void Manager::setRemoteAutoInstall(const tribool &enabled)
tribool Manager::remoteAutoInstall(const Remote &remote) const
{
- const auto it = m_mods.find(remote);
+ const auto &it = m_mods.find(remote);
if(it == m_mods.end())
return remote.autoInstall();
diff --git a/src/remote.cpp b/src/remote.cpp
@@ -135,7 +135,7 @@ void RemoteList::add(const Remote &remote)
return;
size_t index = 0;
- const auto it = m_map.find(remote.name());
+ const auto &it = m_map.find(remote.name());
if(it == m_map.end()) {
// insert remote
@@ -153,7 +153,7 @@ void RemoteList::add(const Remote &remote)
void RemoteList::remove(const string &name)
{
- const auto it = m_map.find(name);
+ const auto &it = m_map.find(name);
if(it == m_map.end())
return;
@@ -170,7 +170,7 @@ void RemoteList::remove(const string &name)
Remote RemoteList::get(const string &name) const
{
- const auto it = m_map.find(name);
+ const auto &it = m_map.find(name);
if(it == m_map.end())
return {};
diff --git a/src/task.cpp b/src/task.cpp
@@ -66,7 +66,7 @@ bool InstallTask::start()
for(const Source *src : m_version->sources()) {
const Path &targetPath = src->targetPath();
- const auto old = find_if(m_oldFiles.begin(), m_oldFiles.end(),
+ const auto &old = find_if(m_oldFiles.begin(), m_oldFiles.end(),
[&](const Registry::File &f) { return f.path == targetPath; });
if(old != m_oldFiles.end())
diff --git a/src/transaction.cpp b/src/transaction.cpp
@@ -113,7 +113,7 @@ vector<IndexPtr> Transaction::getIndexes(const vector<Remote> &remotes) const
vector<IndexPtr> indexes;
for(const Remote &remote : remotes) {
- const auto it = m_indexes.find(remote.name());
+ const auto &it = m_indexes.find(remote.name());
if(it != m_indexes.end())
indexes.push_back(it->second);
}
@@ -158,7 +158,7 @@ void Transaction::fetchIndex(const Remote &remote, const bool stale,
IndexPtr Transaction::loadIndex(const Remote &remote)
{
- const auto it = m_indexes.find(remote.name());
+ const auto &it = m_indexes.find(remote.name());
if(it != m_indexes.end())
return it->second;
@@ -377,7 +377,7 @@ void Transaction::inhibit(const Remote &remote)
// AND prevents files from this remote from being registered in REAPER
// (UNregistering is not affected)
- const auto it = m_syncedRemotes.find(remote.name());
+ const auto &it = m_syncedRemotes.find(remote.name());
if(it != m_syncedRemotes.end())
m_syncedRemotes.erase(it);
