zynaddsubfx

commit 25cbcbec7085ebfd9026265767779f537cc0963e
parent 7d80f747b066485a9274fb2c6a3f30e2335b4484
Author: fundamental <mark.d.mccurry@gmail.com>
Date:   Sun, 28 Aug 2011 09:55:51 -0400

Warnings: Misc fixes

- Removed out-of-date warnings
- Fixed parenthesis issue

Diffstat:
M
src/Misc/LASHClient.cpp
 | 
2
+-
M
src/Misc/Master.cpp
 | 
2
--
M
src/Nio/AlsaEngine.cpp
 | 
4
+---
M
src/Tests/XMLwrapperTest.h
 | 
2
--
M
src/main.cpp
 | 
4
----

5 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/src/Misc/LASHClient.cpp b/src/Misc/LASHClient.cpp
@@ -61,7 +61,7 @@ LASHClient::Event LASHClient::checkevents(std::string &filename)
 
     Event received = NoEvent;
     lash_event_t *event;
-    while(event = lash_get_event(client)) {
+    while((event = lash_get_event(client))) {
         // save
         if(lash_event_get_type(event) == LASH_Save_File) {
             std::cerr << "LASH event: LASH_Save_File" << std::endl;
diff --git a/src/Misc/Master.cpp b/src/Misc/Master.cpp
@@ -21,8 +21,6 @@
 
 */
 
-#warning TODO move Sequencer out of master
-
 #include "Master.h"
 
 #include "../Params/LFOParams.h"
diff --git a/src/Nio/AlsaEngine.cpp b/src/Nio/AlsaEngine.cpp
@@ -337,12 +337,10 @@ void AlsaEngine::stopAudio()
 
 void *AlsaEngine::processAudio()
 {
-    int rc;
     while (audio.handle) {
         audio.buffer = interleave(getNext());
         snd_pcm_t *handle = audio.handle;
-        if(handle)
-            rc = snd_pcm_writei(handle, audio.buffer, SOUND_BUFFER_SIZE);
+        int rc = snd_pcm_writei(handle, audio.buffer, SOUND_BUFFER_SIZE);
         if (rc == -EPIPE) {
             /* EPIPE means underrun */
             cerr << "underrun occurred" << endl;
diff --git a/src/Tests/XMLwrapperTest.h b/src/Tests/XMLwrapperTest.h
@@ -52,8 +52,6 @@ class XMLwrapperTest:public CxxTest::TestSuite
 version-revision=\"1\" ZynAddSubFX-author=\"Nasca Octavian Paul\">\n\
 </ZynAddSubFX-data>\n";
             xmlb->putXMLdata(dat.c_str());
-#warning todo contact mxml people about possible memoryleak when
-#warning       mxmlLoadString is giving something starting with a newline
         }
 
         void tearDown() {
diff --git a/src/main.cpp b/src/main.cpp
@@ -378,10 +378,6 @@ int main(int argc, char *argv[])
     //Run the Nio system
     bool ioGood = Nio::getInstance().start();
 
-
-#warning remove welcome message when system is out of beta
-    cout << "\nThanks for using the Nio system :)" << endl;
-
 #ifndef DISABLE_GUI
     if(noui == 0)
         pthread_create(&thr3, NULL, thread3, (void*)!ioGood);