zynaddsubfx

ZynAddSubFX open source synthesizer
Log | Files | Refs | Submodules | LICENSE

commit adb2d8552320910f84df7fa7c0be5f48e7453d7e
parent 6846d54cdb67c5663504cb758c08f485d53f6bf8
Author: Carlo Bramini <30959007+carlo-bramini@users.noreply.github.com>
Date:   Mon, 25 Oct 2021 11:51:12 +0200

[WIN32] Fix missed creation of lv2 directory.

This patch fixes issue 200:
https://sourceforge.net/p/zynaddsubfx/bugs/200/

The explanation of the defect is described into this page:
https://cmake.org/cmake/help/v3.9/manual/cmake-buildsystem.7.html

In short:
- All versions of Windows are "DLL platforms", and DLL are targets for "bin" directory.
- On all other "non-DLL platforms", the shared libraries are targets for "lib" directory.

This means that:
- On DLL platforms: RUNTIME_OUTPUT_DIRECTORY and RUNTIME_OUTPUT_NAME target properties are used.
- On non-DLL platforms: LIBRARY_OUTPUT_DIRECTORY and LIBRARY_OUTPUT_NAME target properties are used.

So, RUNTIME_OUTPUT_DIRECTORY must be set in addition to LIBRARY_OUTPUT_DIRECTORY for supporting "DLL platforms".

Diffstat:
Msrc/Plugin/AlienWah/CMakeLists.txt | 2++
Msrc/Plugin/Chorus/CMakeLists.txt | 2++
Msrc/Plugin/Distortion/CMakeLists.txt | 2++
Msrc/Plugin/DynamicFilter/CMakeLists.txt | 2++
Msrc/Plugin/Echo/CMakeLists.txt | 2++
Msrc/Plugin/Phaser/CMakeLists.txt | 2++
Msrc/Plugin/Reverb/CMakeLists.txt | 2++
Msrc/Plugin/ZynAddSubFX/CMakeLists.txt | 2++
8 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/src/Plugin/AlienWah/CMakeLists.txt b/src/Plugin/AlienWah/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynAlienWah_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPlugin set_target_properties(ZynAlienWah_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynAlienWah_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynAlienWah_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynAlienWah_lv2 PROPERTIES OUTPUT_NAME "ZynAlienWah") set_target_properties(ZynAlienWah_lv2 PROPERTIES PREFIX "") set_target_properties(ZynAlienWah_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynAlienWah_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynAlienWah_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynAlienWah_vst PROPERTIES OUTPUT_NAME "ZynAlienWah") set_target_properties(ZynAlienWah_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/Chorus/CMakeLists.txt b/src/Plugin/Chorus/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynChorus_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPluginMa set_target_properties(ZynChorus_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynChorus_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynChorus_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynChorus_lv2 PROPERTIES OUTPUT_NAME "ZynChorus") set_target_properties(ZynChorus_lv2 PROPERTIES PREFIX "") set_target_properties(ZynChorus_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynChorus_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynChorus_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynChorus_vst PROPERTIES OUTPUT_NAME "ZynChorus") set_target_properties(ZynChorus_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/Distortion/CMakeLists.txt b/src/Plugin/Distortion/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynDistortion_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPlug set_target_properties(ZynDistortion_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynDistortion_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynDistortion_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynDistortion_lv2 PROPERTIES OUTPUT_NAME "ZynDistortion") set_target_properties(ZynDistortion_lv2 PROPERTIES PREFIX "") set_target_properties(ZynDistortion_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynDistortion_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynDistortion_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynDistortion_vst PROPERTIES OUTPUT_NAME "ZynDistortion") set_target_properties(ZynDistortion_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/DynamicFilter/CMakeLists.txt b/src/Plugin/DynamicFilter/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynDynamicFilter_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoP set_target_properties(ZynDynamicFilter_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynDynamicFilter_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynDynamicFilter_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynDynamicFilter_lv2 PROPERTIES OUTPUT_NAME "ZynDynamicFilter") set_target_properties(ZynDynamicFilter_lv2 PROPERTIES PREFIX "") set_target_properties(ZynDynamicFilter_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynDynamicFilter_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynDynamicFilter_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynDynamicFilter_vst PROPERTIES OUTPUT_NAME "ZynDynamicFilter") set_target_properties(ZynDynamicFilter_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/Echo/CMakeLists.txt b/src/Plugin/Echo/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynEcho_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPluginMain set_target_properties(ZynEcho_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynEcho_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynEcho_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynEcho_lv2 PROPERTIES OUTPUT_NAME "ZynEcho") set_target_properties(ZynEcho_lv2 PROPERTIES PREFIX "") set_target_properties(ZynEcho_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynEcho_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynEcho_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynEcho_vst PROPERTIES OUTPUT_NAME "ZynEcho") set_target_properties(ZynEcho_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/Phaser/CMakeLists.txt b/src/Plugin/Phaser/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynPhaser_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPluginMa set_target_properties(ZynPhaser_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynPhaser_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynPhaser_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynPhaser_lv2 PROPERTIES OUTPUT_NAME "ZynPhaser") set_target_properties(ZynPhaser_lv2 PROPERTIES PREFIX "") set_target_properties(ZynPhaser_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynPhaser_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynPhaser_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynPhaser_vst PROPERTIES OUTPUT_NAME "ZynPhaser") set_target_properties(ZynPhaser_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/Reverb/CMakeLists.txt b/src/Plugin/Reverb/CMakeLists.txt @@ -6,11 +6,13 @@ add_library(ZynReverb_vst SHARED ${CMAKE_SOURCE_DIR}/DPF/distrho/DistrhoPluginMa set_target_properties(ZynReverb_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynReverb_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") +set_target_properties(ZynReverb_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynReverb_lv2 PROPERTIES OUTPUT_NAME "ZynReverb") set_target_properties(ZynReverb_lv2 PROPERTIES PREFIX "") set_target_properties(ZynReverb_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynReverb_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynReverb_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynReverb_vst PROPERTIES OUTPUT_NAME "ZynReverb") set_target_properties(ZynReverb_vst PROPERTIES PREFIX "") diff --git a/src/Plugin/ZynAddSubFX/CMakeLists.txt b/src/Plugin/ZynAddSubFX/CMakeLists.txt @@ -135,12 +135,14 @@ endif() if(NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Windows") set_target_properties(ZynAddSubFX_lv2 PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_LV2") set_target_properties(ZynAddSubFX_lv2 PROPERTIES LIBRARY_OUTPUT_DIRECTORY "lv2") + set_target_properties(ZynAddSubFX_lv2 PROPERTIES RUNTIME_OUTPUT_DIRECTORY "lv2") set_target_properties(ZynAddSubFX_lv2 PROPERTIES OUTPUT_NAME "ZynAddSubFX") set_target_properties(ZynAddSubFX_lv2 PROPERTIES PREFIX "") endif() set_target_properties(ZynAddSubFX_vst PROPERTIES COMPILE_DEFINITIONS "DISTRHO_PLUGIN_TARGET_VST2") set_target_properties(ZynAddSubFX_vst PROPERTIES LIBRARY_OUTPUT_DIRECTORY "vst") +set_target_properties(ZynAddSubFX_vst PROPERTIES RUNTIME_OUTPUT_DIRECTORY "vst") set_target_properties(ZynAddSubFX_vst PROPERTIES OUTPUT_NAME "ZynAddSubFX") set_target_properties(ZynAddSubFX_vst PROPERTIES PREFIX "")